Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update all dependencies #226

Closed
wants to merge 2 commits into from
Closed

chore: update all dependencies #226

wants to merge 2 commits into from

Conversation

victorb
Copy link
Member

@victorb victorb commented May 7, 2018

License: MIT
Signed-off-by: Victor Bjelkholm [email protected]

License: MIT
Signed-off-by: Victor Bjelkholm <[email protected]>
@ghost ghost assigned victorb May 7, 2018
@ghost ghost added the status/in-progress In progress label May 7, 2018
License: MIT
Signed-off-by: Victor Bjelkholm <[email protected]>
@victorb victorb requested review from daviddias and dignifiedquire and removed request for daviddias May 7, 2018 12:51
@victorb
Copy link
Member Author

victorb commented May 7, 2018

This works! Managed to release aegir-test-repo with these changes, and aegir spawns even faster now (and webpack builds seems faster, but I have not measured to YMMV)

@diasdavid @dignifiedquire can I have some reviews?

Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what the observable polyfill is needed for, but the rest looks good. Though I'd like to have a look from someone second :)

@daviddias daviddias requested a review from hugomrdias May 7, 2018 14:18
@daviddias
Copy link
Member

Pinging @hugomrdias to share some of his Webpack 4 wisdom here.

Copy link
Member

@hugomrdias hugomrdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@daviddias
Copy link
Member

@victorbjelkholm before merging, you might want to give it a spin on js-ipfs and its examples. Just to triple check that the bundle is sound.

@victorb
Copy link
Member Author

victorb commented May 8, 2018

I don't know what the observable polyfill is needed for, but the rest looks good. Though I'd like to have a look from someone second :)

Pulled in and required because listr requires observables to exists before loading the module, new change in the module, hence added in this commit.

before merging, you might want to give it a spin on js-ipfs and its examples. Just to triple check that the bundle is sound.

Good point, will do! Thanks

@jacobheun
Copy link
Contributor

I am using this branch against the js-ipfs node 10 fixes, ipfs/js-ipfs#1358. The jenkins builds look good in node 8, 9 and 10.

This branch looks good from my end. Can we get it merged and released?

@victorb
Copy link
Member Author

victorb commented May 22, 2018

Will do! I just need to test js-ipfs + examples, then I'll merge if everything looks good.

@achingbrain
Copy link
Member

Can you merge #231 first? This PR has a few dep version changes that violate our dep policy - #231 will flag those up during the linting step.

@vmx
Copy link
Member

vmx commented Jun 22, 2018

@victorbjelkholm Can you rebase this one? There's lots of "npm audit" noise due to AEgir, I'd really love to see this merged.

@victorb
Copy link
Member Author

victorb commented Jul 5, 2018

Will submit new PR as this is outdated by now...

@victorb victorb closed this Jul 5, 2018
@ghost ghost removed the status/in-progress In progress label Jul 5, 2018
@daviddias daviddias deleted the upgrade-deps branch July 5, 2018 10:53
@victorb victorb restored the upgrade-deps branch July 5, 2018 10:54
@victorb victorb deleted the upgrade-deps branch July 5, 2018 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants