-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update all dependencies #226
Conversation
License: MIT Signed-off-by: Victor Bjelkholm <[email protected]>
License: MIT Signed-off-by: Victor Bjelkholm <[email protected]>
This works! Managed to release aegir-test-repo with these changes, and aegir spawns even faster now (and webpack builds seems faster, but I have not measured to YMMV) @diasdavid @dignifiedquire can I have some reviews? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what the observable polyfill is needed for, but the rest looks good. Though I'd like to have a look from someone second :)
Pinging @hugomrdias to share some of his Webpack 4 wisdom here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
@victorbjelkholm before merging, you might want to give it a spin on js-ipfs and its examples. Just to triple check that the bundle is sound. |
Pulled in and required because listr requires observables to exists before loading the module, new change in the module, hence added in this commit.
Good point, will do! Thanks |
I am using this branch against the js-ipfs node 10 fixes, ipfs/js-ipfs#1358. The jenkins builds look good in node 8, 9 and 10. This branch looks good from my end. Can we get it merged and released? |
Will do! I just need to test js-ipfs + examples, then I'll merge if everything looks good. |
@victorbjelkholm Can you rebase this one? There's lots of "npm audit" noise due to AEgir, I'd really love to see this merged. |
Will submit new PR as this is outdated by now... |
License: MIT
Signed-off-by: Victor Bjelkholm [email protected]