Make test descriptions more explicit. Use 'err' instead of 'e'.

ipfs-inactive · Mar 23, 2017 · 94d8bbc · 94d8bbc
1 parent 599020b
commit 94d8bbc
Showing 1 changed file with 25 additions and 25 deletions.
diff --git a/test/pubsub-in-browser.spec.js b/test/pubsub-in-browser.spec.js
@@ -76,7 +76,7 @@ if (!isNode) {
     describe('everything errors', () => {
       describe('Callback API', () => {
         describe('.publish', () => {
-          it('throws an error', (done) => {
+          it('throws an error if called in the browser', (done) => {
             ipfs1.pubsub.publish(topic, 'hello friend', (err, topics) => {
               expect(err).to.exist
               expect(err.message).to.equal(expectedError)
@@ -87,7 +87,7 @@ if (!isNode) {
 
         describe('.subscribe', () => {
           const handler = () => {}
-          it('throws an error', (done) => {
+          it('throws an error if called in the browser', (done) => {
             ipfs1.pubsub.subscribe(topic, {}, handler, (err, topics) => {
               expect(err).to.exist
               expect(err.message).to.equal(expectedError)
@@ -97,7 +97,7 @@ if (!isNode) {
         })
 
         describe('.peers', () => {
-          it('throws an error', (done) => {
+          it('throws an error if called in the browser', (done) => {
             ipfs1.pubsub.peers(topic, (err, topics) => {
               expect(err).to.exist
               expect(err.message).to.equal(expectedError)
@@ -107,7 +107,7 @@ if (!isNode) {
         })
 
         describe('.ls', () => {
-          it('throws an error', (done) => {
+          it('throws an error if called in the browser', (done) => {
             ipfs1.pubsub.ls((err, topics) => {
               expect(err).to.exist
               expect(err.message).to.equal(expectedError)
@@ -119,57 +119,57 @@ if (!isNode) {
 
       describe('Promise API', () => {
         describe('.publish', () => {
-          it('throws an error', () => {
+          it('throws an error if called in the browser', () => {
             return ipfs1.pubsub.publish(topic, 'hello friend')
-              .catch((e) => {
-                expect(e).to.exist
-                expect(e.message).to.equal(expectedError)
+              .catch((err) => {
+                expect(err).to.exist
+                expect(err.message).to.equal(expectedError)
               })
           })
         })
 
         describe('.subscribe', () => {
           const handler = () => {}
-          it('throws an error', (done) => {
+          it('throws an error if called in the browser', (done) => {
             ipfs1.pubsub.subscribe(topic, {}, handler)
-              .catch((e) => {
-                expect(e).to.exist
-                expect(e.message).to.equal(expectedError)
+              .catch((err) => {
+                expect(err).to.exist
+                expect(err.message).to.equal(expectedError)
                 done()
               })
           })
         })
 
         describe('.peers', () => {
-          it('throws an error', (done) => {
+          it('throws an error if called in the browser', (done) => {
             ipfs1.pubsub.peers(topic)
-              .catch((e) => {
-                expect(e).to.exist
-                expect(e.message).to.equal(expectedError)
+              .catch((err) => {
+                expect(err).to.exist
+                expect(err.message).to.equal(expectedError)
                 done()
               })
           })
         })
 
         describe('.ls', () => {
-          it('throws an error', () => {
+          it('throws an error if called in the browser', () => {
             return ipfs1.pubsub.ls()
-              .catch((e) => {
-                expect(e).to.exist
-                expect(e.message).to.equal(expectedError)
+              .catch((err) => {
+                expect(err).to.exist
+                expect(err.message).to.equal(expectedError)
               })
           })
         })
       })
 
       describe('.unsubscribe', () => {
-        it('throws an error', (done) => {
+        it('throws an error if called in the browser', (done) => {
           try {
-            ipfs1.pubsub.unsubscribe(topic)
+            ipfs1.pubsub.unsubscribe()
             done('unsubscribe() didn\'t throw an error')
-          } catch (e) {
-            expect(e).to.exist
-            expect(e.message).to.equal(expectedError)
+          } catch (err) {
+            expect(err).to.exist
+            expect(err.message).to.equal(expectedError)
             done()
           }
         })