-
Notifications
You must be signed in to change notification settings - Fork 20
ci: add gateway-confromance test suite to the CI #66
Conversation
@galargh I re-enabled the subdomain conformance tests. For this, I added an additional env variable so that we configure the right subdomain to "listen on" (example.com). Additionally, I noticed the proxy tunnel tests were failing, making the conformance tests panic [please investigate why the conformance tests panic'ed]! I also fixed that on the last commit. Apparently, we did not support the Other than that, amazing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thank you @galargh!
Some questions about logistics below.
docs/environment-variables.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ added docs for env variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging, so we have more confidence in things like #61
Resolves #63
This PR adds https://github.com/ipfs/gateway-conformance to the CI here.
We set up Kubo backed bifrost-gateway for the tests.
We keep
subdomain-gateway
spec testing disabled because: https://github.com/ipfs/bifrost-gateway/actions/runs/4511354942We keep
TestGatewayCar
disabled because: https://github.com/ipfs/bifrost-gateway/actions/runs/4511433301References to
ipfs/gateway-conformance
will be replaced with proper release tags once we have any (i.e. once we have release process set up - ipfs/gateway-conformance#19).