Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removeReferencesToVendoredSourcesHook: dedup references #745

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Conversation

ipetkov
Copy link
Owner

@ipetkov ipetkov commented Nov 23, 2024

Motivation

Debug builds might have a ton of references to sources, and sed does not like it when we feed it a massive amount of duplicates

Fixes #744

Checklist

  • added tests to verify new behavior
  • added an example template or updated an existing one
  • updated docs/API.md (or general documentation) with changes
  • updated CHANGELOG.md

Debug builds might have a ton of references to sources, and `sed` does
not like it when we feed it a massive amount of duplicates
@ipetkov ipetkov enabled auto-merge (squash) November 23, 2024 23:55
@ipetkov ipetkov merged commit f2b4b47 into master Nov 24, 2024
19 checks passed
@ipetkov ipetkov deleted the remove-refs branch November 24, 2024 00:12
ulucs pushed a commit to ulucs/crane that referenced this pull request Dec 3, 2024
Debug builds might have a ton of references to sources, and `sed` does
not like it when we feed it a massive amount of duplicates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

removeReferencesToVendoredSourcesHook uses 18GB of memory
1 participant