Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removeReferencesToVendoredSources: cache vendorDir crawling #625

Merged
merged 4 commits into from
May 25, 2024
Merged

Conversation

ipetkov
Copy link
Owner

@ipetkov ipetkov commented May 25, 2024

Motivation

There is no reason to repeatedly crawl the vendor directories for each installed file, we can easily cache the results once up front.

Fixes #620

Checklist

  • added tests to verify new behavior
  • added an example template or updated an existing one
  • updated docs/API.md (or general documentation) with changes
  • updated CHANGELOG.md

There is no reason to repeatedly crawl the vendor directories for each
installed file, we can easily cache the results once up front.
@ipetkov ipetkov enabled auto-merge (squash) May 25, 2024 23:35
@ipetkov ipetkov merged commit 701dbc1 into master May 25, 2024
19 checks passed
@ipetkov ipetkov deleted the refs branch May 25, 2024 23:45
@9999years
Copy link
Contributor

I think xargs --no-run-if-empty signIfRequired is introducing an error to my build because signIfRequired is a shell function and not an executable, so xargs can't find it:

https://github.com/NixOS/nixpkgs/blob/7187b3ee8e2687106e8982b02d2890689471579e/pkgs/os-specific/darwin/signing-utils/utils.sh#L38-L43

xargs: signIfRequired: No such file or directory

Maybe we can work around by doing something like this:

https://github.com/NixOS/nixpkgs/blob/7187b3ee8e2687106e8982b02d2890689471579e/pkgs/os-specific/darwin/signing-utils/auto-sign-hook.sh#L19-L21

@9999years 9999years mentioned this pull request May 29, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallelize removeReferencesToVendoredSourcesHook
2 participants