-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the repo compile under ROS Lunar (OpenCV 3.2.0) #72
Conversation
This Github issue helped a lot: wg-perception/people#44
The build has failed, which is what I expected, as some names in OpenCV 3 have changed. I think I can try to make those changes depending on the OpenCV version. I'll try to make something compatible in the next few days. |
Many thanks! Well done. I guess you can easily make it work with both OpenCV versions using this macro
|
The build failed trying to execute code for OpenCV 3. |
No problem. Thanks for your assistance. I will fix the errors for OpenCV 2 and complement your pull request so that Travis is happy. Again, many thanks for your contribution. By the way, a new colleague of mine will extend the functionality of this package significantly, soon, especially with major improvements on the person recognition quality. So stay tuned. |
OPENCV_MAJOR_VERSION was wrong, CV_MAJOR_VERSION seem to be correct, sorry for the wrong hint. |
Now you received a pull request from me. Can you please merge them in order to update this pull request? |
Fixes for opencv 2 in indigo
This Github issue helped a lot:
wg-perception/people#44
I haven't tested it, it "just" compiles.
This is an open discussion, so if improvements are needed, please tell :)