Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index.js: import prop types from deprecated package #229

Merged

Conversation

stevekuznetsov
Copy link
Contributor

package-lock.json: update to new version

This commit was generated by:

rm package-lock.json
npm install

Without this commit, I was getting errors downloading packages from
nexus.bybutter.com repositories. I'm not clear why those were the
resolved sources in the past, but they do not seem to be required.

Signed-off-by: Steve Kuznetsov [email protected]


index.js: import prop types from deprecated package

This new import path is required for newer versions of React Native.

Signed-off-by: Steve Kuznetsov [email protected]


cc @iou90
Fixes #228

This commit was generated by:

rm package-lock.json
npm install

Without this commit, I was getting errors downloading packages from
nexus.bybutter.com repositories. I'm not clear why those were the
resolved sources in the past, but they do not seem to be required.

Signed-off-by: Steve Kuznetsov <[email protected]>
This new import path is required for newer versions of React Native.

Signed-off-by: Steve Kuznetsov <[email protected]>
@ThirupathaiahR
Copy link

Please import viewPropTypes from from deprecated-react-native-prop-types instead of react-native.
Please do it as early as possible.

@iou90 iou90 changed the base branch from master to v1.6.2 July 18, 2022 08:00
@iou90 iou90 merged commit a0c23ff into iou90:v1.6.2 Jul 18, 2022
iou90 added a commit that referenced this pull request Jul 18, 2022
* index.js: import prop types from deprecated package (#229)

* package-lock.json: update to new version

This commit was generated by:

rm package-lock.json
npm install

Without this commit, I was getting errors downloading packages from
nexus.bybutter.com repositories. I'm not clear why those were the
resolved sources in the past, but they do not seem to be required.

Signed-off-by: Steve Kuznetsov <[email protected]>

* index.js: import prop types from deprecated package

This new import path is required for newer versions of React Native.

Signed-off-by: Steve Kuznetsov <[email protected]>

* Bump version to 1.6.2

Co-authored-by: Steve Kuznetsov <[email protected]>
@iou90
Copy link
Owner

iou90 commented Jul 18, 2022

Please import viewPropTypes from from deprecated-react-native-prop-types instead of react-native. Please do it as early as possible.

Sorry for the late reply >.<
It should be fixed on v1.6.2. (https://github.com/iou90/react-native-autoheight-webview/releases/tag/v1.6.2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ViewPropTypes from 'deprecated-react-native-prop-types'
3 participants