update libp2p to v0.32.2 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
dustinxie
reviewed
Jul 26, 2024
p2p.go
Outdated
| } | ||
|
|
||
| if !cfg.SecureIO { | ||
| opts = append(opts, libp2p.NoSecurity) | ||
| } else { | ||
| opts = append(opts, libp2p.Security(secio.ID, secio.New)) | ||
| // opts = append(opts, libp2p.Security(secio.ID, secio.New)) |
There was a problem hiding this comment.
secio is already deprecated:
secio is not maintained any more, and we advise against using it.
Use go-libp2p-tls and go-libp2p-noise instead.
and tls and noise is the two default security of libp2p, so we can just remove it
dustinxie
reviewed
Jul 26, 2024
| @@ -634,7 +642,7 @@ func (h *Host) AddBootstrap(bootNodeAddrs []multiaddr.Multiaddr) error { | |||
| } | |||
|
|
|||
| // HostIdentity returns the host identity string | |||
| func (h *Host) HostIdentity() string { return h.host.ID().Pretty() } | |||
| func (h *Host) HostIdentity() string { return h.host.ID().String() } | |||
There was a problem hiding this comment.
confirm Pretty() is renamed to String()?
There was a problem hiding this comment.
yes, they are all base58-encoded
dustinxie
reviewed
Jul 26, 2024
| } | ||
|
|
||
| // relay option | ||
| if cfg.Relay == "active" { | ||
| opts = append(opts, libp2p.EnableRelay(relay.OptActive, relay.OptHop)) | ||
| opts = append(opts, libp2p.EnableRelay()) |
There was a problem hiding this comment.
there is no options any more in the new version.
dustinxie
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.