Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Remove
relay
andmdns
features that were used in the code to automatically implement certain behaviour, which is bad practice as features are additive (see #210 (comment)).Instead enable / disable mdns and relay functionality on init via config flags in the
StrongholdP2pBuilder
, per default both are enabled in the builder.In the Stronghold client, mdns and relay can be enabled/ disabled via the
NetworkConfig
when spawning the p2p-network actor. Per default, both are disabled for Stronghold.Type of change
How the change has been tested
Added new tests for mdns and relay configuration.
Change checklist
Add an
x
to the boxes that are relevant to your changes, and delete any items that are not.