Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2p/configure features #276

Merged
merged 6 commits into from
Nov 1, 2021
Merged

P2p/configure features #276

merged 6 commits into from
Nov 1, 2021

Conversation

elenaf9
Copy link
Contributor

@elenaf9 elenaf9 commented Oct 29, 2021

Description of change

Remove relay and mdns features that were used in the code to automatically implement certain behaviour, which is bad practice as features are additive (see #210 (comment)).
Instead enable / disable mdns and relay functionality on init via config flags in the StrongholdP2pBuilder, per default both are enabled in the builder.
In the Stronghold client, mdns and relay can be enabled/ disabled via the NetworkConfig when spawning the p2p-network actor. Per default, both are disabled for Stronghold.

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Added new tests for mdns and relay configuration.

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@elenaf9 elenaf9 requested a review from felsweg-iota October 29, 2021 15:25
Copy link
Contributor

@felsweg-iota felsweg-iota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Appreciate the change from feature gates to a config based approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants