Feat/comms behaviour protocol

.changes/config.json

@@ -94,8 +94,8 @@
         "stronghold-utils"
       ]
     },
-    "stronghold-communication": {
-      "path": "./communication/",
+    "stronghold-p2p": {
+      "path": "./p2p/",
       "manager": "rust",
       "dependencies": [
         "stronghold-utils"
@@ -106,7 +106,7 @@
       "manager": "rust",
       "dependencies": [
         "stronghold-engine",
-        "stronghold-communication",
+        "stronghold-p2p",
         "stronghold-utils",
         "stronghold-runtime"
       ]

.changes/fuzzer.md

@@ -1,5 +1,4 @@
 ---
-"stronghold-communication": minor
 "stronghold-engine": patch
 ---
 

.changes/readme.md

@@ -7,12 +7,12 @@
 | ---- | ------- | -------- | ------- | ----------------- |
 | iota-stronghold | The Client | Rust | Yes | Yes |
 | stronghold-engine | The Engine | Rust | Yes | Yes |
-| stronghold-communication | Communication Subsystem | Rust | Yes | No |
+| stronghold-p2p | Communication Subsystem | Rust | Yes | No |
 | runtime | Secure Zone | Rust | Yes | No |
 | vault | Engine's memory Store | Rust | No | No |
 | snapshot | Engine's Persistence | Rust | No | No |
 | store | Engine's Readable Storage Interface | Rust | No | No |
-| communication-macros | Communication macros | Rust | No | No |
+| stronghold-derive | Stronghold Procedural Macros | Rust | No | No |
 | stronghold-utils | Reoccuring Patterns, and Utilities for Testing | Rust | No | No |
 
 As you create PRs and make changes that require a version bump, please add a new markdown file in this folder. You do not note the version _number_, but rather the type of bump that you expect: major, minor, or patch. The filename is not important, as long as it is a `.md`, but we recommend it represents the overall change for our sanity.

.github/dependabot.yml

@@ -7,7 +7,7 @@ updates:
     open-pull-requests-limit: 3
 
   - package-ecosystem: "cargo"
-    directory: "/communication"
+    directory: "/p2p"
     schedule:
       interval: "daily"
     open-pull-requests-limit: 3

.github/workflows/clippy.yml

@@ -19,7 +19,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        project: [engine, client, products/commandline, derive, utils, communication]
+        project: [engine, client, products/commandline, derive, utils, p2p]
 
     steps:
       - uses: actions/checkout@v2

.github/workflows/format.yml

@@ -19,7 +19,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        project: [engine, client, products/commandline, derive, utils, communication]
+        project: [engine, client, products/commandline, derive, utils, p2p]
 
     steps:
       - uses: actions/checkout@v2

.github/workflows/test.yml

@@ -19,7 +19,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        project: [engine, client, products/commandline, derive, utils, communication]
+        project: [engine, client, products/commandline, derive, utils, p2p]
         os: [ubuntu-latest, macos-latest, windows-latest]
 
     steps:

Cargo.toml

@@ -3,7 +3,7 @@ members = [
   "engine",
   "engine/runtime",
   "client",
-  "communication",
+  "p2p",
   "utils",
   "derive"
 ]

README.md

@@ -16,7 +16,7 @@
 There are four main components of Stronghold:
 1. **Client**: The high-level interface to Stronghold (prefers Riker, functional integration also available)
 2. **Engine**: Combines a persistence store (Snapshot) with an in-memory state interface (Vault), a read/write key:value system (Store) and memory protection services (Runtime).
-3. **Communication**: Enables Strongholds in different processes or on different devices to communicate with each other securely.
+3. **P2P**: Enables Strongholds in different processes or on different devices to communicate with each other securely.
 
 ## 3rd Party Independent Security Audit
 In April of 2021, F-Secure performed a security assessment of the core crates of IOTA Stronghold and found nothing of concern. This is not an explicit declaration of fitness or freedom of error, but it is an indicator of the high quality of the code. You may review [the audit here](https://github.com/iotaledger/stronghold.rs/blob/dev/documentation/docs/meta/Audit.pdf).

client/Cargo.toml

@@ -21,6 +21,7 @@ zeroize = "1.1"
 zeroize_derive = "1.0"
 anyhow = "1.0"
 thiserror = "1.0"
+futures = { version = "0.3", optional = true }
 actix = "0.12"
 
 [dependencies.stronghold_engine]
@@ -39,17 +40,19 @@ features = [
 "chacha"
 ]
 
-[dependencies.stronghold-communication]
-path = "../communication"
+
+[dependencies.stronghold-p2p]
+path = "../p2p"
+version = "0.3"
 optional = true
-version = "0.4.1"
 
 [dependencies.stronghold-utils]
 path = "../utils"
 version = "0.3"
 
 [features]
-communication = [ "stronghold-communication" ]
+p2p = ["stronghold-p2p", "futures"]
+
 
 [dev-dependencies]
 hex = "0.4.2"
@@ -58,6 +61,11 @@ clap = { version = "3.0.0-beta.1", features = [ "yaml" ] }
 rand = "0.8.3"
 tokio = {version = "1.9", features = ["rt-multi-thread"] }
 
+[[example]]
+name = "p2p"
+required-features = ["p2p"]
+
+
 [[bench]]
 name = "benchmark"
 harness = false

client/examples/comm/README.md → client/examples/p2p/README.md

@@ -1,22 +1,21 @@
-# Stronghold Communication Example
+# Stronghold P2P-Network Example
 
-
-The communication examples show the networking capabilities of stronghold.
+The network examples show the p2p-networking capabilities of stronghold.
 Some are just "one-shot" examples to show what is possible with stronghold in an easy way
 
 ## Quickstart
 
-Run following command to show sample output for the communications example:
+Run following command to show sample output for the network example:
 
-```
-cargo run --features communication comm
+```sh
+cargo run --features p2p p2p
 ```
 
 This will display some helpful output
 
-```
-Stronghold Example Communications 
-Example to show stronghold's communication capabilities
+```sh
+Stronghold Example P2P-Network 
+Example to show stronghold's p2p-networking capabilities
 
 USAGE:
     comm [actor-path] <SUBCOMMAND>
@@ -36,24 +35,26 @@ SUBCOMMANDS:
     swarm-info    Displays information on this node
 ```
 
-
 ## Listen for connections
+
 To start stronghold to listen for remote peer connections, you can run
 
 ```no_run
-cargo run --features communication --example comm listen --multiaddr "/ip4/127.0.0.1/tcp/7001"
+cargo run --features p2p --example p2p listen --multiaddr "/ip4/127.0.0.1/tcp/7001"
 ```
 
 ## Show swarm info
+
 To show info on neighbouring peers you can run
 
 ```no_run
-cargo run --features communication --example comm swarm-info
+cargo run --features p2p --example p2p swarm-info
 ```
 
 ## Add Peer(s)
+
 Peers can also be added by running
 
 ```no_run
-cargo run --features communication --example comm
+cargo run --features p2p --example p2p
 ```

client/examples/comm/arguments.rs → client/examples/p2p/arguments.rs

@@ -6,8 +6,8 @@ use clap::{Clap, Subcommand};
 
 #[derive(Clap, Debug)]
 #[clap(
-    name = "Stronghold Example Communications",
-    about = "Example to show stronghold's communication capabilities"
+    name = "Stronghold Example P2p-Network",
+    about = "Example to show stronghold's p2p-network capabilities"
 )]
 pub struct ExampleApp {
     #[clap(subcommand)]
@@ -19,15 +19,15 @@ pub struct ExampleApp {
 
 #[derive(Debug, Subcommand)]
 pub enum Commands {
-    #[cfg(feature = "communication")]
+    #[cfg(feature = "p2p")]
     #[clap(alias = "peers", about = "Lists all peers.")]
     Peers {},
 
-    #[cfg(feature = "communication")]
+    #[cfg(feature = "p2p")]
     #[clap(alias = "swarm-info", about = "Displays information on this node")]
     SwarmInfo {},
 
-    #[cfg(feature = "communication")]
+    #[cfg(feature = "p2p")]
     #[clap(about = "Start listening on multiaddress.")]
     Listen {
         #[clap(