Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update evm rpcs #1696

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Update evm rpcs #1696

wants to merge 11 commits into from
+234 −100

Conversation

Dr-Electron
Copy link
Collaborator

@Dr-Electron Dr-Electron commented Feb 11, 2025 •
edited
Loading

Description of change

Formated and sorted the old RPC list and added the new ones.

TODO:

  • Add links and descriptions to the missing RPCs

Links to any relevant issues

Fixes #1694.

Type of change

  • Documentation Fix

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work
  • I have commented my code, particularly in hard-to-understand areas

@Dr-Electron Dr-Electron marked this pull request as ready for review February 17, 2025 21:07
@Dr-Electron
Copy link
Collaborator Author

Got a little confused by this message: https://github.com/iotaledger/wasp/blob/ec9252d1d1813ed0e42359d469a75c7265f160e7/packages/evm/jsonrpc/service.go#L36

Because there is no Subscribe function, but there is Logs and NewHeads which are parameters for eth_subscribe.
Also there doesn't seem to be an Unsubscribe function. But using wscat I can unsubscribe. But there is also a defer function on the NewHeads and Logs function. Does that mean they get Unsubscribed automatically?

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 7f3fc0e

✅ Preview: https://iota-wiki-3guy7xpba-iota1.vercel.app

@Dr-Electron Dr-Electron changed the base branch from main to update-wasp-docs February 18, 2025 08:53
Base automatically changed from update-wasp-docs to main February 18, 2025 21:48
@Dr-Electron Dr-Electron marked this pull request as draft February 18, 2025 22:09
@Dr-Electron Dr-Electron marked this pull request as ready for review February 18, 2025 22:09
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 9ac7ce0

✅ Preview: https://iota-wiki-7ksb5g9as-iota1.vercel.app

vivekjain23
vivekjain23 reviewed Feb 19, 2025
View reviewed changes
docs/build/isc/v1.5/docs/reference/json-rpc-spec.md
| [eth_getTransactionByBlockNumberAndIndex] | _Returns information about a transaction by block number and transaction index position_ | ✅ |
| [eth_getTransactionByHash] | _Returns the information about a transaction requested by transaction hash_ | ✅ |
| [eth_getTransactionCount] | _Returns the number of transactions sent from an address_ | ✅ |
| [eth_getTransactionReceipt] | _Returns the receipt of a transaction by transaction hash_ | ✅ |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is redirecting to the JSON RPC API page, not the api.

docs/build/isc/v1.6/docs/reference/json-rpc-spec.md
| [eth_getTransactionByBlockNumberAndIndex] | _Returns information about a transaction by block number and transaction index position_ | ✅ |
| [eth_getTransactionByHash] | _Returns the information about a transaction requested by transaction hash_ | ✅ |
| [eth_getTransactionCount] | _Returns the number of transactions sent from an address_ | ✅ |
| [eth_getTransactionReceipt] | _Returns the receipt of a transaction by transaction hash_ | ✅ |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same issue as above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivekjain23 vivekjain23 vivekjain23 left review comments

@lucas-tortora lucas-tortora lucas-tortora approved these changes

@lmoe lmoe Awaiting requested review from lmoe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update EVM RPC endpoints
3 participants
@Dr-Electron @lucas-tortora @vivekjain23