Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a link to Subscriptions from Advanced Features #433

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

Freso
Copy link
Contributor

@Freso Freso commented Mar 24, 2024

I keep going to Advanced Features’ Subscriptions section for the link and missing the link in the header of the page. Surely I’m not the only one… right? 😅

Copy link

This pull request is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Apr 23, 2024
@iorate
Copy link
Owner

iorate commented Apr 23, 2024

unstale

Copy link
Owner

@iorate iorate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the website is SPA (and internationalized), the link should point to /subscriptions, not an absolute path URL.

@Freso Freso force-pushed the link-advanced-features-subscriptions branch from 24975ee to 1a03d22 Compare April 24, 2024 10:51
@Freso
Copy link
Contributor Author

Freso commented Apr 24, 2024

I’m not sure what "SPA" means here, but /subscriptions would make the link point to https://iorate.github.io/subscriptions which yields a 404, since starting with / is what makes it an absolute path. Updated PR with a relative path (subscriptions).

@iorate
Copy link
Owner

iorate commented Apr 24, 2024

fixed my comment:

- an absolute path
+ an absolute URL

/subscriptions is processed by Docusaurus to point to https://iorate.github.io/ublacklist/subscriptions.

I keep going to Advanced Features’ Subscriptions section for the
link and missing the link in the header of the page. Surely I’m
not the only one… right? 😅
@Freso Freso force-pushed the link-advanced-features-subscriptions branch from 1a03d22 to 0653e51 Compare April 24, 2024 13:24
Copy link
Owner

@iorate iorate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@iorate iorate merged commit 34da6c5 into iorate:master Apr 24, 2024
1 check passed
@Freso Freso deleted the link-advanced-features-subscriptions branch April 29, 2024 08:20
Copy link

github-actions bot commented May 5, 2024

🎉 This PR is included in version 8.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants