-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a link to Subscriptions from Advanced Features #433
Add a link to Subscriptions from Advanced Features #433
Conversation
This pull request is stale because it has been open for 30 days with no activity. |
unstale |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the website is SPA (and internationalized), the link should point to /subscriptions
, not an absolute path URL.
24975ee
to
1a03d22
Compare
I’m not sure what "SPA" means here, but |
fixed my comment: - an absolute path
+ an absolute URL
|
I keep going to Advanced Features’ Subscriptions section for the link and missing the link in the header of the page. Surely I’m not the only one… right? 😅
1a03d22
to
0653e51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
🎉 This PR is included in version 8.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I keep going to Advanced Features’ Subscriptions section for the link and missing the link in the header of the page. Surely I’m not the only one… right? 😅