Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch out webpack #1722

Closed
wants to merge 3 commits into from
Closed

Switch out webpack #1722

wants to merge 3 commits into from

Conversation

AngelMunoz
Copy link
Contributor

@baronfel following from #1721 (comment)
This is a more serious attempt at #1672 this PR takes out webpack stuff and uses rollup, the main reason why we one used webpack + babel (assuming things here correct me if I'm wrong) was mainly to be able to use modern syntax in unsupported browsers (or in this case electron) thankfully everything that Fable emits today is well supported so we just need the bundler and some tree shaking for production builds

I gave it a spin locally and all seems to work just fine but let me know if something is fishy

@nojaf
Copy link
Contributor

nojaf commented Jun 13, 2022

This is a more serious attempt at #1672

Ouch, that is quite painful to read, to be honest. There was never anything unserious about my PR.
Please review https://github.com/ionide/ionide-vscode-fsharp/blob/main/CODE_OF_CONDUCT.md#our-standards going forward.

@AngelMunoz
Copy link
Contributor Author

I'm sorry @nojaf when I say serious I meant vs my previous attempt which was a mere comment on the original issue, and a deleted branch on my deleted fork, I re-tried to tackle this issue again but in a more positive tone vs my own previous attempts, I didn't mean to cause any harm to you or anyone, I tagged you on your other PR just for us to be in sync. I never meant any harm I'm sorry I didn't phrase that correctly 😔

@nojaf
Copy link
Contributor

nojaf commented Jun 13, 2022

Apology accepted @AngelMunoz.

@AngelMunoz
Copy link
Contributor Author

closing out in favor of #1684 unless someone else has any other inputs

@AngelMunoz AngelMunoz closed this Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants