Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Log Filter (fsacSilencedLogs) doesn't work when multiple categories specified #1541

Merged
merged 1 commit into from
Jun 20, 2021

Conversation

Booksbaum
Copy link
Contributor

Reason: Categories are combined into comma-separated list of categories, which is emitted as single string:

  • Setting:
    "FSharp.fsac.silencedLogs": [
      "FileSystem",
      "Compiler",
    ]
  • passed into FsAutoComplete:
    --filter "FileSystem,Compiler"
    

-> interpreted in FsAutoComplete as single category "FileSystem,Compiler" instead of two categories.

Correct filter for FsAutoComplete:

--filter FileSystem Compiler

(List with categories separated by space)

@baronfel baronfel merged commit 5f01b1b into ionide:master Jun 20, 2021
@baronfel
Copy link
Contributor

Good fix, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants