Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using workspace.rootPath #1204

Open
roblourens opened this issue Aug 24, 2019 · 2 comments
Open

Avoid using workspace.rootPath #1204

roblourens opened this issue Aug 24, 2019 · 2 comments
Labels
enhancement Accepted suggestions that makes existing features better up for grabs Good first issues

Comments

@roblourens
Copy link

This extension appears to be using the workspace.rootPath API. This is a deprecated property and may not work as expected. Please use workspaceFolders instead. More info: https://github.com/microsoft/vscode/wiki/Adopting-Multi-Root-Workspace-APIs#eliminating-rootpath

microsoft/vscode#69335
@open-collective-bot
Copy link

Hey @roblourens 👋,

Thank you for opening an issue. We will get back to you as
soon as we can. Also, check out our OpenCollective and consider
backing us.

https://opencollective.com/ionide

PS.: We offer backer support for all backers. Don't forget to add backer label when you start backing us 😄

@Krzysztof-Cieslak Krzysztof-Cieslak added enhancement Accepted suggestions that makes existing features better up for grabs Good first issues labels Sep 17, 2019
@baronfel baronfel mentioned this issue Mar 5, 2021
Open
6 tasks
@baronfel
Copy link
Contributor

baronfel commented Mar 5, 2021 •
edited
Loading

There might be some work here in this repo, but most of the logic related to workspace handling is actually in FSAutoComplete, so I've raised a more detailed issue there.

sharno added a commit to sharno/ionide-vscode-fsharp that referenced this issue Oct 6, 2021
@sharno
Fix ionide#1204
5e8cb6d 
replace all rootPath usages with workspaceFolders using only the first one (support one workspace folder)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Accepted suggestions that makes existing features better up for grabs Good first issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@roblourens @baronfel @Krzysztof-Cieslak