Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build project and packages #187

Merged
merged 1 commit into from
May 12, 2023
Merged

Conversation

jkillingsworth
Copy link
Contributor

@jkillingsworth jkillingsworth commented May 12, 2023

I get warnings about the FAKE runner being out of date whenever I build and run.

shot-1

I also get squigglies on the first line of the build.fsx file.

shot-2

It looks like the dependencies haven't been updated in a while, so I went ahead and did the updates. I decided to use a dedicated build project instead of using the FAKE runner since this approach seems to be the current best practice.

References:

I am using the build projects in the following repos as examples:

The first thing I did was remove the FAKE runner tool using this command:

dotnet tool uninstall fake-cli

Then I created a dedicated build project:

dotnet new console --name build --language F#
dotnet sln SyntaxTest.sln add ./build/build.fsproj

I copied the code from the build.fsx file into the main function of the dedicated build project and then removed the build.fsx file. I copied the code as-is, so there are no changes to the behaviors. I also replaced the fake.cmd and fake.sh files with corresponding build.cmd and build.sh files.

This is the old way to invoke the build:

./fake.sh build -t BuildExtension

This is the new way to invoke the build:

./build.sh -t BuildExtension

The tasks.json file has been updated to reflect these changes, so you can just press F5 from within VS Code and it works the same as before.

I also updated the Paket tool and updated all the packages:

dotnet tool update paket
dotnet paket update

These changes do not affect any of the grammar definitions.

@baronfel
Copy link

LGTM! Thanks for updating the infrastructure here 👍

@baronfel baronfel merged commit db77c2a into ionide:master May 12, 2023
@jkillingsworth jkillingsworth deleted the updates branch May 12, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants