Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable unnecessary parentheses analyzer by default #1336

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

brianrourkeboll
Copy link
Contributor

@TheAngryByrd TheAngryByrd merged commit c8546f6 into ionide:main Dec 31, 2024
14 checks passed
@brianrourkeboll brianrourkeboll deleted the enable-parens-analyzer branch December 31, 2024 16:56
@enriquein
Copy link

Now that this is the default, how would one disable it? I tried this on my vscode settings but it still runs the analyzer:

    "FSharp.excludeAnalyzers": [
        "UnnecessaryParenthesesAnalyzer"
    ]

@brianrourkeboll
Copy link
Contributor Author

Now that this is the default, how would one disable it? I tried this on my vscode settings but it still runs the analyzer:

    "FSharp.excludeAnalyzers": [
        "UnnecessaryParenthesesAnalyzer"
    ]

I see it as a checkbox under the F# extension settings:

image

If you want to set it directly in your settings JSON, I believe it would be:

"FSharp.unnecessaryParenthesesAnalyzer": false

@enriquein
Copy link

Thank you! I'm not sure how I missed that. Sorry for the false alarm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants