Refactoring ActivityListener Notfications

ionide · Feb 24, 2023 · 0e610cf · 0e610cf
1 parent f2cc59b
commit 0e610cf
Show file tree

Hide file tree

Showing 4 changed files with 271 additions and 136 deletions.
diff --git a/paket.lock b/paket.lock
@@ -393,7 +393,7 @@ GITHUB
   remote: TheAngryByrd/FsLibLog
     src/FsLibLog/FsLibLog.fs (64f118ae8df2f2944ef69758052cb3b148b87e79)
   remote: TheAngryByrd/FsOpenTelemetry
-    src/FsOpenTelemetry/FsOpenTelemetry.fs (3e2c3a836fec05ef1621ec37ef57246f487c72c5)
+    src/FsOpenTelemetry/FsOpenTelemetry.fs (fb24e8d4dc8ad14187b9b4631854fc8f17fb244d)
 GROUP Build
 STORAGE: NONE
 RESTRICTION: || (== net6.0) (== net7.0)

diff --git a/src/FsAutoComplete.Core/Utils.fs b/src/FsAutoComplete.Core/Utils.fs
@@ -839,17 +839,25 @@ module Tracing =
   open StreamJsonRpc
 
   module SemanticConventions =
-    [<Literal>]
-    let sourceCodePath = "fsac.sourceCodePath"
 
-    let setTagSourceCodePath filePath (a: Activity) =
-      a.SetTagSafe(sourceCodePath, filePath) |> ignore
+    module FCS =
+      [<Literal>]
+      let fileName = "fileName"
+
+      [<Literal>]
+      let project = "project"
+
+      [<Literal>]
+      let qualifiedNameOfFile = "qualifiedNameOfFile"
+
+      [<Literal>]
+      let userOpName = "userOpName"
 
     [<Literal>]
-    let projectFilePath = "fsac.projectFilePath"
+    let fsac_sourceCodePath = "fsac.sourceCodePath"
 
-    let setTagProjectFilePath filePath (a: Activity) =
-      a.SetTagSafe(projectFilePath, filePath) |> ignore
+    [<Literal>]
+    let projectFilePath = "fsac.projectFilePath"
 
   [<Literal>]
   let serviceName = "FsAutoComplete"