Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FCS to 43.9.201 #226

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Update FCS to 43.9.201 #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08e61ae
Update FCS to 43.9.201
TheAngryByrd Feb 13, 2025
096ed4f
chore: maybe fix CI complaints
TheAngryByrd Feb 13, 2025
17f537a
force 9.0.101 sdk becaues of
TheAngryByrd Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,16 @@ jobs:
uses: actions/setup-dotnet@v4
with:
global-json-file: 'global.json'
# 9.0.101 because of https://github.com/dotnet/fsharp/issues/18298#issuecomment-2655277169
dotnet-version: |
8.x
9.x

8.x
9.0.101
- name: Build
run: dotnet fsi build.fsx

- name: Upload documentation
if: github.ref == 'refs/heads/main'
uses: actions/upload-pages-artifact@v1
uses: actions/upload-pages-artifact@v3
with:
path: ./output

Expand All @@ -45,4 +45,4 @@ jobs:
steps:
- name: Deploy to GitHub Pages
id: deployment
uses: actions/deploy-pages@v1
uses: actions/deploy-pages@v4
4 changes: 2 additions & 2 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
</PropertyGroup>
<ItemGroup>
<PackageVersion Include="CliWrap" Version="3.6.4" />
<PackageVersion Include="FSharp.Core" Version="[9.0.100]" />
<PackageVersion Include="FSharp.Compiler.Service" Version="[43.9.100]" />
<PackageVersion Include="FSharp.Core" Version="[9.0.201]" />
<PackageVersion Include="FSharp.Compiler.Service" Version="[43.9.201]" />
<PackageVersion Include="Ionide.KeepAChangelog.Tasks" Version="0.1.8" PrivateAssets="all" />
<PackageVersion Include="McMaster.NETCore.Plugins" Version="1.4.0" />
<PackageVersion Include="Argu" Version="6.1.1" />
Expand Down
3 changes: 1 addition & 2 deletions global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"sdk": {
"version": "9.0.100",
"rollForward": "latestMinor"
"version": "9.0.101"
}
}
6 changes: 3 additions & 3 deletions src/FSharp.Analyzers.SDK/ASTCollecting.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,14 +288,14 @@ module ASTCollecting =
| SynExpr.InferredUpcast(expr = e)
| SynExpr.InferredDowncast(expr = e)
| SynExpr.AddressOf(expr = e)
| SynExpr.DoBang(e, _)
| SynExpr.DoBang(e, _, _)
| SynExpr.YieldOrReturn(expr = e)
| SynExpr.ArrayOrListComputed(expr = e)
| SynExpr.ComputationExpr(expr = e)
| SynExpr.Do(e, _)
| SynExpr.Assert(e, _)
| SynExpr.Lazy(e, _)
| SynExpr.YieldOrReturnFrom(_, e, _) -> walkExpr nextPath e
| SynExpr.YieldOrReturnFrom(_, e, _, _) -> walkExpr nextPath e
| SynExpr.SequentialOrImplicitYield(expr1 = e1; expr2 = e2; ifNotStmt = ifNotE) ->
walkExpr nextPath e1
walkExpr nextPath e2
Expand Down Expand Up @@ -498,7 +498,7 @@ module ASTCollecting =
| SynMemberDefn.Interface(t, _, members, _) ->
walkType nextPath t
members |> Option.iter (List.iter (walkMember nextPath))
| SynMemberDefn.Inherit(baseType = t) -> walkType nextPath t
| SynMemberDefn.Inherit(baseType = t) -> t |> Option.iter (walkType nextPath)
| SynMemberDefn.ValField(field, _) -> walkField nextPath field
| SynMemberDefn.NestedType(typeDefn = tdef) -> walkTypeDefn nextPath tdef
| SynMemberDefn.AutoProperty(attributes = AllAttrs attrs; typeOpt = t; synExpr = e; range = _) ->
Expand Down