This repository has been archived by the owner on Sep 15, 2021. It is now read-only.
Fix nativeAudio plugin parameters #1195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing parameter on the `preloadComplex` function and fix parameter’s order in the `play` function.
|
We had to upgrade our Jasmine instance. Thanks to #1174; it was fixed. Try again? And please target dev-next. Sorry about that. |
|
Can't you rerun the builds on Travis instead of closing the PRs? |
|
Closing and re-opening the PR seems to trigger another build. That makes me happy. |
|
@samaxes Still would have to close this PR. It needs to target dev-next, not Master. |
|
Just submitted new PR #1203. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing parameter on the
preloadComplexfunction and fix parameter’s order in theplayfunction.Fixes issue #669.