fix(icon): set fill on host element and remove stroke #688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the
fill
property to the host element and removes thestroke
sinceA) I couldn't find any of our icons that even use stroke
B) I don't see any of the custom icons needing stroke a specific color by default
C) It allows the user to change these properties if desired on the
<ion-icon>
itself without needing CSS variablesD) It still inherits the color that gets set
This also updates the test to include custom icons.
This would fix ionic-team/ionic-framework#16483, but I need to do some testing in Ionic for it.
Below is a comparison between master and this branch, where the "Custom CSS" group is specifically setting the following:
master
branch