Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

menu with header (beta10) #676

Closed
brandyscarney opened this issue Jun 30, 2016 · 3 comments
Closed

menu with header (beta10) #676

brandyscarney opened this issue Jun 30, 2016 · 3 comments

Comments

@brandyscarney
Copy link
Member

From @movrack on June 30, 2016 8:30

Since beta 10, my menu have some view problem. Middle down part of it is empty.

In breaking changes I see we must insert toolbar inside header/footer or content.
But, it's not updated in doc for menus. (toolbar is always outside ion-content tag)
http://ionicframework.com/docs/v2/components/#menus

How we should use menus and toolbar in menu ?

Copied from original issue: ionic-team/ionic-framework#7138

@brandyscarney
Copy link
Member Author

From @imjohnbo on June 30, 2016 13:58

The toolbar should also be inside a header. Check out Step 3 of Steps to Upgrade to Beta 10, and this quote from the Changelog:

The only elements that should be children of a page are ion-header, ion-content, and ion-footer

It normally takes a couple of days for the doc to reflect changes from a new beta release.

@brandyscarney
Copy link
Member Author

Thanks for the issue! I'm going to move this to the ionic-site repo to make sure the docs are updated for this. 😄

To answer your question: The menu toolbar should be similar to a page where the ion-toolbar is inside of an ion-header or ion-footer.

@mhartington
Copy link
Contributor

Right now we have it noted in http://ionicframework.com/docs/v2/components/#toolbar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants