Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs about ion-toolbar always being first child on page #660

Closed
jgw96 opened this issue Jun 23, 2016 · 6 comments
Closed

docs about ion-toolbar always being first child on page #660

jgw96 opened this issue Jun 23, 2016 · 6 comments
Assignees

Comments

@jgw96
Copy link
Contributor

jgw96 commented Jun 23, 2016

We should add a note to the toolbar docs about the toolbar always needing to be the first child on a page. Related issue: ionic-team/ionic-framework#6392

@brandyscarney
Copy link
Member

This is actually going to change with the next release since we're wrapping them in ion-header's. Also, the ion-content can be the first-child as well if there is no toolbar/header.

@brandyscarney
Copy link
Member

We need to add documentation that a page should only have the following direct children:

<ion-header/>
<ion-content/>
<ion-footer/>

@mhartington
Copy link
Contributor

This could be a good place for a general view component section in the component docs

Go over the anatomy of a view component and such.
Actually would this be a good fit for the component docs or the getting started guide?

@brandyscarney
Copy link
Member

Related issues: #685 #676

@mhartington
Copy link
Contributor

waiting on this before moving forward. #700

@mhartington mhartington self-assigned this Jul 29, 2016
@mhartington
Copy link
Contributor

Right now we have it noted in http://ionicframework.com/docs/v2/components/#toolbar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants