Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix on-hold for Some devices #4703

Merged
merged 1 commit into from
Dec 6, 2015
Merged

Conversation

Elyahou
Copy link

@Elyahou Elyahou commented Dec 3, 2015

Fix on-hold callback that are not fired on Galaxy S6 and some other android 5.1 devices

See #4672

Maybe related to https://forum.ionicframework.com/t/issues-with-on-hold-event-on-android/14051/17

and https://forum.ionicframework.com/t/ionic-view-android-gesture-issues/21807

@mlynch mlynch added this to the 1.2 milestone Dec 6, 2015
mlynch added a commit that referenced this pull request Dec 6, 2015
fix on-hold for Some devices
@mlynch mlynch merged commit 60f9403 into ionic-team:master Dec 6, 2015
@mlynch
Copy link
Contributor

mlynch commented Dec 6, 2015

Thanks! Just tested this and it seems like a decent fix. Appreciate the contribution!

@borodatych
Copy link

Samsung Galaxy s6 android 5.1.1 the problem is the place to be

@borodatych
Copy link

Earned after(https://forum.ionicframework.com/t/issues-with-on-hold-event-on-android/14051/13):

You can add overflow-scroll="true" in the ion-content, but not in a div.

Without it will not work, or I missed something?

@borodatych
Copy link

It is not working properly - now works ng-click after on-hold

@borodatych
Copy link

Final result:

<ion-content overflow-scroll="true">
    <ion-item ng:repeat="(key,item) in items" on:tap="clickMethod(item)" on:hold="holdMethod(item)">
        CONTENT
    </ion-item>
</ion-content>

It is a pity that without the use of overflow-scroll =" true " does not work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants