Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): add default link color #4580

Merged
merged 1 commit into from
Dec 6, 2015
Merged

fix(): add default link color #4580

merged 1 commit into from
Dec 6, 2015

Conversation

5im0n
Copy link
Contributor

@5im0n 5im0n commented Oct 31, 2015

The variables $link-color and $link-hover-color are not used in the Ionic style.

When you write a link directly in a ion-content it takes the ugly default blue color of the browser.
I suggest to used this variables to make links more friendlier 🎨.

mlynch added a commit that referenced this pull request Dec 6, 2015
fix(): add default link color
@mlynch mlynch merged commit 896c476 into ionic-team:master Dec 6, 2015
@mlynch
Copy link
Contributor

mlynch commented Dec 6, 2015

Thanks :)

@andreialecu
Copy link

@5im0n @mlynch This breaks things by affecting tabs. Hovering over one makes it blue now.

I think it should be scoped to just ion-content maybe.

mlynch added a commit that referenced this pull request Dec 8, 2015
@mlynch
Copy link
Contributor

mlynch commented Dec 8, 2015

Removed the hover, we're good 👍

@5im0n 5im0n deleted the fix-link-color branch December 8, 2015 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants