ionHeaderBar: Do not scroll the ScrollView if the no-tap-scroll attribute is set #4466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I decided to just remove this functionality completely and, instead, listen for the native |
|
👍 |
|
unfortunately, this fix makes the header-bar buggy. I think previous version was better for UX :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some case one does not want the ScrollView to scroll to the top of the list when tapping the title of the headerbar. Think of scenarios where the
h1would link to a different view, or trigger a modal being shown.Instead of checking for all possible attributes that could trigger this (such as
ui-sref,href,ng-click), a genericno-tap-scroll` would also afford this. This PR introduces the latter.