Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed incorrect order of $ionicView and $ionicNavView events. #3804

Closed
wants to merge 2 commits into from
Closed

Fixed incorrect order of $ionicView and $ionicNavView events. #3804

wants to merge 2 commits into from
+75 −19

Conversation

bodinaren
Copy link

Solves issue #3800

Based on the original behavior I worked under the assumption that navigating from view 1 to view 2 should trigger events in the following order (given that neither is cached):

$ionicView.loaded (view 2)
$ionicView.beforeEnter (view 2)
$ionicView.beforeLeave (view 1)
$ionicView.enter (view 2)
$ionicView.leave (view 1)
$ionicView.afterEnter (view 2)
$ionicView.afterLeave (view 1)
$ionicView.unloaded (view 1)

@bodinaren bodinaren changed the title Fixed incorrect order of $ionicView and $ionicNavView events. #3800 Fixed incorrect order of $ionicView and $ionicNavView events. May 21, 2015
@perrygovier
Copy link
Contributor

@adamdbradley, can you give this your seal of approval? I'd like to get this in to 1.0.1

@perrygovier perrygovier added this to the 1.0.1 milestone May 22, 2015
@bodinaren
Copy link
Author

Perhaps leave events before enter events makes more sense tho? I could switch them around in that case.

perrygovier added a commit that referenced this pull request Jun 12, 2015
@perrygovier
fix(viewSwitcher): Broadcast view transition events in a consistent o…
f78b1b3 
…rder Closes #3804
perrygovier pushed a commit that referenced this pull request Jun 12, 2015
@bodinaren @perrygovier
fix(viewSwitcher): Broadcast view transition events in a consistent o…
fa918ee 
…rder Closes #3804
@perrygovier perrygovier removed the ready label Jun 12, 2015
@perrygovier
Copy link
Contributor

merged in fa918ee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adamdbradley adamdbradley

Labels
None yet
Projects
None yet
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@bodinaren @perrygovier @adamdbradley