Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let ionicons load for WP8 #3154

Merged
merged 1 commit into from
May 1, 2015
Merged

let ionicons load for WP8 #3154

merged 1 commit into from
May 1, 2015

Conversation

Alain-Bearez
Copy link

This is a minimalist short term fix before a complete solution be implemented as was discussed in #2599.

@adamdbradley
Copy link
Contributor

Why can't WP8 take a font url with a querystring?

@Alain-Bearez
Copy link
Author

I might suppose it is a "feature" specific to IE on Windows Phone. Removing the query string from the URL is a trick used in several places, according to what I read from the Google search I did when facing this issue with Windows Phone.

Some interesting reading on the subject are the following posts:
http://www.paulirish.com/2009/bulletproof-font-face-implementation-syntax/
http://www.fontspring.com/blog/the-new-bulletproof-font-face-syntax
https://css-tricks.com/snippets/css/using-font-face/

perrygovier added a commit that referenced this pull request May 1, 2015
fix(fonts): IE does not support query string cache busting in font URLs
@perrygovier perrygovier merged commit bd72a33 into ionic-team:master May 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants