Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): IonNav works with react #25565

Merged
merged 19 commits into from
Jul 6, 2022
Merged

fix(react): IonNav works with react #25565

merged 19 commits into from
Jul 6, 2022

Conversation

sean-perkins
Copy link
Contributor

@sean-perkins sean-perkins commented Jul 1, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

IonNav does not work within React since the framework delegate is not set.

Issue URL: #24002

What is the new behavior?

  • Sets the framework delegate for IonNav
  • IonNav works within React

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev-build: 6.1.12-dev.11656705976.18fe5a46

Documentation changes will be accounted for in another PR/task for IonNav playground.

@github-actions github-actions bot added the package: react @ionic/react package label Jul 1, 2022
@sean-perkins sean-perkins marked this pull request as ready for review July 1, 2022 20:50
@sean-perkins sean-perkins requested a review from a team as a code owner July 1, 2022 20:50
@averyjohnston averyjohnston requested a review from liamdebeasi July 5, 2022 19:14
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Can we post a dev build on the issue thread for others to test?

@sean-perkins sean-perkins merged commit 420f9bb into main Jul 6, 2022
@sean-perkins sean-perkins deleted the FW-1753-a branch July 6, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react @ionic/react package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants