Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): interface components now show correctly #24810

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #24807

In dev mode, overlay components are not treeshaken, so they are defined in the custom elements registry. In prod mode they are, so these overlays do not show when using ion-select.

What is the new behavior?

  • Overlay components are added to ion-select such that Stencil will automatically define them when calling defineCustomElement

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Feb 17, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review February 17, 2022 15:20
@liamdebeasi liamdebeasi requested a review from a team as a code owner February 17, 2022 15:20
@liamdebeasi
Copy link
Contributor Author

Adding tests soon

@liamdebeasi
Copy link
Contributor Author

liamdebeasi commented Feb 17, 2022

I updated tests as part of a separate PR #24812. The existing tests should fail if overlays do not load.

@sean-perkins sean-perkins requested a review from a team February 17, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: select is not defining popover which causes it to not show in production builds
3 participants