Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): inline modals and popovers now add .ion-page class correctly #24751

Merged
merged 5 commits into from
Feb 9, 2022

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #24750

This fixes a regression caused by 596aad4. When using inline overlays with Angular, the inner content is not available at the time of overlay creation. As a result, a stray .ion-page div was being added that later covered the entire modal content, making it non-interactive.

What is the new behavior?

  • Do not append .ion-page element if there are no children to append to.
  • Ensure all inline modals+popovers have the .ion-page class added

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi requested a review from a team as a code owner February 9, 2022 15:24
@github-actions github-actions bot added package: angular @ionic/angular package package: core @ionic/core package labels Feb 9, 2022
Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me (assuming all tests pass).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: release 6.0.6 breaks my ion-datetime modal - should this method still work?
3 participants