Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(item): mirror disabled prop to aria attribute #23544

Merged
merged 10 commits into from
Jul 9, 2021
Merged

Conversation

willmartian
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves #23513

What is the new behavior?

  • Components with the disabled property now reflect that in aria-disabled, for better screen reader support.

Does this introduce a breaking change?

  • Yes
  • No

@willmartian willmartian requested a review from liamdebeasi June 30, 2021 19:34
@github-actions github-actions bot added package: core @ionic/core package package: vue @ionic/vue package labels Jun 30, 2021
@github-actions github-actions bot removed the package: vue @ionic/vue package label Jun 30, 2021
@willmartian willmartian changed the title fix(a11y): mirror disabled prop to aria attribute fix(item): mirror disabled prop to aria attribute Jul 9, 2021
@willmartian willmartian merged commit 9021e7c into master Jul 9, 2021
@willmartian willmartian deleted the fix/23513 branch July 9, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: aria-disabled is not automatically applied
2 participants