fix(progress-bar): flip rtl using the existing reversed property #17464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brandyscarney should I close #17382? |
|
@abennouna Yeah I think so. Does this PR work for you or do you see any issues with it? |
|
@brandyscarney sorry for the delay; just ran the 3 included tests in both MD and iOS, in both RTL and LTR, everything's works just fine :-) |
kiku-jw
pushed a commit
to kiku-jw/ionic
that referenced
this pull request
May 16, 2019
…ic-team#17464) updates the progress bar to always use the ltr dir but take advantage of the reversed property when dir is rtl. references ionic-team#17012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Updates the progress bar to always use the
ltrdirbut take advantage of thereversedproperty when dir isrtl.references #17012