Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(loading): add missing async to new loading example #17432

Merged
merged 3 commits into from
Feb 7, 2019
Merged

docs(loading): add missing async to new loading example #17432

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f2f1e3
update loading example
liamdebeasi Feb 7, 2019
4e98dfe
add async
liamdebeasi Feb 7, 2019
3c31b16
Merge branch 'master' into update-loading-breaking-example
liamdebeasi Feb 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add async
  • Loading branch information
@liamdebeasi
liamdebeasi committed Feb 7, 2019
commit 4e98dfe7e9e0f9ab22c243e67c7c0d60ac9afc7f
2 changes: 1 addition & 1 deletion angular/BREAKING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1061,7 +1061,7 @@ openLoading() {
**New Usage Example:**

```javascript
openLoading() {
async openLoading() {
let loading = this.loadingCtrl.create({
content: 'Loading...'
});
Expand Down