Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(angular): add test for slides #17085

Merged
merged 2 commits into from
Jan 14, 2019

Conversation

paulstelzer
Copy link
Contributor

@paulstelzer paulstelzer commented Jan 13, 2019

Ion-Slides is not working in production build like mentioned in #17032 and #17033

This issue was not fixed by #17037

Fix for no is to remove sideEffects - better solution would be great :)

@paulstelzer paulstelzer changed the title test: slides test(angular): add test for slides Jan 14, 2019
@manucorporat manucorporat merged commit 8357e5c into ionic-team:master Jan 14, 2019
@adamduren
Copy link
Contributor

@paulstelzer According to the webpack documentation this can affect the ability to tree shake. Is there any information on the effects this change had? Also if you know what specific files have side effects they can be listed individually as an array to sideEffects vs a boolean.

Documentation

@paulstelzer
Copy link
Contributor Author

paulstelzer commented Jan 16, 2019

This is just a temporary fix until we find something else. If we add sideEffects again, the build will be broken and slides are not working. sideEffects was activated with rc1, so rc0 was without it and all betas, too

and yes, only slides had this sideEffects, so in future only this can be excluded. but as I said it's just a temporary fix to make Ionic work again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants