feat(radio-group): add missing implementation for property allowEmptySelection #16880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manucorporat
suggested changes
Dec 28, 2018
Co-Authored-By: kplhub <[email protected]>
|
One last thing, you need to merge master, npm install, npm run build and the commit the updated files too. |
…s://github.com/kplhub/ionic into 4.0.0-rc.0__radio-group__allow-empty-selection
This reverts commit b93a53d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Resolves: Missing implementation of deselection in a radio-group: #16841
Changes proposed in this pull request:
-In radio: added @event() ionDeselect, which is emitted from OnClick if the radio is already checked
-In radio-group: added @listen('ionDeselect'), which, if allowEmptySelection property is true, will uncheck radio and set radio-group value to undefined
Ionic Version: core 4.0.0-rc.0
Fixes: #16841