Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-add 'hidden="true"' attribute to hide tabs (thansk @sebmartel) #1673

Closed
wants to merge 1 commit into from
Closed

re-add 'hidden="true"' attribute to hide tabs (thansk @sebmartel) #1673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions release/js/ionic.bundle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43531,6 +43531,7 @@ function($rootScope, $animate, $ionicBind, $compile) {
//We create the tabNavTemplate in the compile phase so that the
//attributes we pass down won't be interpolated yet - we want
//to pass down the 'raw' versions of the attributes
if (attr.hidden !== 'true') {
var tabNavTemplate = '<ion-tab-nav' +
attrStr('ng-click', attr.ngClick) +
attrStr('title', attr.title) +
Expand All @@ -43541,6 +43542,7 @@ function($rootScope, $animate, $ionicBind, $compile) {
attrStr('badge-style', attr.badgeStyle) +
attrStr('class', attr['class']) +
'></ion-tab-nav>';
}

//Remove the contents of the element so we can compile them later, if tab is selected
//We don't use regular transclusion because it breaks element inheritance
Expand Down