Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): add class based APIs #16665

Merged
merged 7 commits into from
Dec 11, 2018
Merged

fix(react): add class based APIs #16665

merged 7 commits into from
Dec 11, 2018

Conversation

manucorporat
Copy link
Contributor

@manucorporat manucorporat commented Dec 10, 2018

fixes #16583

  • [ion-activatable] => .ion-activatable
  • Add contentId prop to ion-split-pane, just like ion-menu so the "main" content can be specified using the element's id.
  • Add ion- prefixed classes to all the CSS utils

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Dec 10, 2018
@manucorporat manucorporat merged commit 2933f61 into master Dec 11, 2018
@manucorporat manucorporat deleted the react-class-apis branch December 11, 2018 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split-pane uses invalid attribute for identifying main.
2 participants