Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for fab-button border properties #16656

Merged
merged 5 commits into from
Dec 10, 2018
Merged

Add support for fab-button border properties #16656

merged 5 commits into from
Dec 10, 2018

Conversation

Maistho
Copy link
Contributor

@Maistho Maistho commented Dec 10, 2018

Short description of what this resolves:

Adds support for custom properties for border-radius, border-style, border-width and border-color on fab-button.

Fixes: #16652

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Dec 10, 2018
@brandyscarney
Copy link
Member

This looks great, thanks!

@manucorporat do we want to set defaults for:

border-width: var(--border-width);
border-style: var(--border-style);
border-color: var(--border-color);

or is this good?

@brandyscarney brandyscarney merged commit 64557a7 into ionic-team:master Dec 10, 2018
@brandyscarney
Copy link
Member

Thanks again! This will be in the next release, 4.0.0-beta.18!

@Maistho
Copy link
Contributor Author

Maistho commented Dec 10, 2018

Lovely, thanks for the quick review! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manucorporat manucorporat manucorporat approved these changes

@brandyscarney brandyscarney brandyscarney approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Maistho @brandyscarney @manucorporat