-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(components): remove unnecessary css variables #16600
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moves to the host element
This reverts commit f625d14.
…into css-vars-sizing
- fixes a bug where the spinner color wasn't being set properly - adds css variables for customizing background, size, spinner color
…into css-vars-sizing
…into css-vars-sizing
- fixes a bug where prefix, suffix are taking up too much width - allows for customizing height, width vars as well as background, color, and border properties - adds e2e example of calling a picker without datetime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviews the
--width
and--height
variables in each component to either remove or add them based on need.Components
Remove the
--width
and--height
variables from the following:Problem Components:
--height
variable to determine the border-radius.--size
variable that will be set to the width and height, allowing width and height to still be set and border-radius to still use a variable--width
/--height
and an--inner-width
/--inner-height
. While we could remove the--width
and--height
, the inner width controls the checked state (iOS checkmark / MD dot). We could just hardcode these, or keep theinner-*
variables. I can't find a good way to use the parent width and not expose these.Investigate Components:
The following components should be shadow (or scoped) with CSS variables for width/height since the wrapper will need it:
The above components will now have the following CSS variables for consistency among overlays:
--height
--max-height
--max-width
--min-height
--min-width
--width
If the component does not set the value, it will default to
auto
.BREAKING CHANGES
The following CSS properties have been removed:
--height
--margin-bottom
--margin-end
--margin-start
--margin-top
--width
--height
--size
--width
--size
--width
--height
--margin-bottom
--margin-end
--margin-start
--width-small
--width
--width
--height
--inner-height
--inner-width
Closes #16097