Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs (item) : docs improvement, issue #16440 #16448

Merged
merged 13 commits into from
Jan 11, 2019

Conversation

sankhaKarunasekara
Copy link
Contributor

Short description of what this resolves:

This is related to issue #16440. better correlation between Docs and Preview. only changed ion-item docs.

Changes proposed in this pull request:

this will improve the correlation between Usage Documents and Preview in the API documentation. https://beta.ionicframework.com/docs/api/item

@sankhaKarunasekara sankhaKarunasekara changed the title Docs changes 16440 docs (item) : docs improvement, issue #16440 Nov 27, 2018
@manucorporat
Copy link
Contributor

Thanks for the PR! we will review very soon!

@brandyscarney brandyscarney merged commit 275d385 into ionic-team:master Jan 11, 2019
@brandyscarney
Copy link
Member

Thanks for the PR! I went ahead and merged this but please note in the future we will be removing the demos from the API page and updating the components documentation to include usage + matching demos. 🙂

@sankhaKarunasekara
Copy link
Contributor Author

that's great news...!! & Thanks for the update. 🙂

@sankhaKarunasekara sankhaKarunasekara deleted the docs-changes-16440 branch January 14, 2019 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants