fix(ion-datetime): convert DatetimeData to ISO string #15833
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Modifies the datetime component to emit the ISO string for the value changed when the value changes. The value itself gets set to the picker structure, so that is no good as something to emit.
NOTE: it may at some point be better to rewrite the component to not use
this.value
as the value returned from the picker, but that would be a much larger and much more error prone rewrite at this point. I would want proper tests in place first.Changes proposed in this pull request:
Ionic Version: 4.x
Fixes: #15408