Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Sass duplication in alerts from checkbox/radio #5577

Closed
brandyscarney opened this issue Feb 23, 2016 · 0 comments
Closed

Clean up Sass duplication in alerts from checkbox/radio #5577

brandyscarney opened this issue Feb 23, 2016 · 0 comments
Assignees
@brandyscarney
Milestone
2.0.0-beta.4

Comments

@brandyscarney
Copy link
Member

Lots of duplication going on in alert, :after being used in some places and checkbox-inner in others
@brandyscarney brandyscarney self-assigned this Feb 23, 2016
@brandyscarney brandyscarney added this to the 2.0.0-beta.3 milestone Mar 1, 2016
@brandyscarney brandyscarney mentioned this issue Mar 3, 2016
Closed
brandyscarney added a commit that referenced this issue Mar 14, 2016
@brandyscarney
refactor(alert): add extra div to use as radio mark, fix Sass
131c8c3 
Added spaces to separate groups of css, added variables, removed unused
css

BREAKING CHANGE: added Sass variables for alert

fixes #5577
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brandyscarney brandyscarney

Labels
None yet
Projects
None yet
Milestone
2.0.0-beta.4
Development

No branches or pull requests
3 participants
@adamdbradley @brandyscarney @Ionitron