Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: router-outlet getRouteId() should returns the params #24652

Closed
4 of 6 tasks
vicb opened this issue Jan 25, 2022 · 2 comments · Fixed by #24656
Closed
4 of 6 tasks

bug: router-outlet getRouteId() should returns the params #24652

vicb opened this issue Jan 25, 2022 · 2 comments · Fixed by #24656
Labels
package: core @ionic/core package type: bug a confirmed bug report

Comments

@vicb
Copy link
Contributor

vicb commented Jan 25, 2022

Prerequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x

Current Behavior

getRouteId() should returns the params to be consistent with ion-nav

It will also enable fixing a bug (I'll create a separate one)

Expected Behavior

Returns the params passed to setRouteId().

Steps to Reproduce

Call getRouteId() params are nor returned.

I'll create a PR with tests.

Code Reproduction URL

No response

Ionic Info

No response

Additional Information

No response
@ionitron-bot ionitron-bot bot added the triage label Jan 25, 2022
This was referenced Jan 25, 2022
Closed
Merged
@liamdebeasi liamdebeasi added package: core @ionic/core package type: bug a confirmed bug report labels Feb 9, 2022
@ionitron-bot ionitron-bot bot removed the triage label Feb 9, 2022
liamdebeasi pushed a commit that referenced this issue Feb 9, 2022
@vicb
fix(router-outlet): getRouteId() returns the params set in setRouteId…
be2205e 
…(). (#24656)

resolves #24652
@liamdebeasi
Copy link
Contributor

Fixed via #24656

This was referenced Mar 1, 2022
Closed
Closed
@ionitron-bot
Copy link

ionitron-bot bot commented Mar 11, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(router-outlet): getRouteId() method now returns parameters vicb/ionic-framework
2 participants
@vicb @liamdebeasi