Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review if ionChange events should bubble up #17071

Closed
manucorporat opened this issue Jan 11, 2019 · 1 comment
Closed

Review if ionChange events should bubble up #17071

manucorporat opened this issue Jan 11, 2019 · 1 comment

Comments

@manucorporat
Copy link
Contributor

Currently all ionChange events bubble up, this can cause troubles if an component that emits this event is nested inside another component that can also emit the same event.

<ion-tabs (ionChange)="event()">
  ...
  <ion-checkbox></ion-checkbox>
</ion-tabs>

Should we make ionChange events to NOT bubble up or should we use different event names if the component can have slotted elements?

@ionitron-bot
Copy link

ionitron-bot bot commented Feb 13, 2019

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Feb 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant