Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Translate the Time Period (am/pm) in ion-datetime #16279

Closed
1001daysofcode opened this issue Nov 8, 2018 · 8 comments
Closed

feat: Translate the Time Period (am/pm) in ion-datetime #16279

1001daysofcode opened this issue Nov 8, 2018 · 8 comments
Labels
package: core @ionic/core package type: feature request a new feature, enhancement, or improvement

Comments

@1001daysofcode
Copy link

1001daysofcode commented Nov 8, 2018

Bug Report

Ionic Info

@ionic/[email protected]

Ionic: 

   ionic (Ionic CLI) : 4.2.1 (/Users/troydcthompson/.nvm/versions/node/v8.9.4/lib/node_modules/ionic)

Cordova:

   cordova (Cordova CLI) : 8.0.0
   Cordova Platforms     : none
   Cordova Plugins       : no whitelistedplugins (0 plugins total)

System:

   ios-deploy : 2.0.0
   NodeJS     : v8.9.4 (/Users/troydcthompson/.nvm/versions/node/v8.9.4/bin/node)
   npm        : 6.4.0
   OS         : macOS High Sierra
   Xcode      : Xcode 9.3 Build version 9E145

Describe the Bug
There isn't a way to translate the am/pm time period in ion-datetime, whereas we can translate the cancelText, doneText, monthShortName, etc.

Steps to Reproduce
Steps to reproduce the behavior:

  1. Implement ion-datetime,
  2. Enter cancelText, doneText, monthShortName variables
  3. Try to enter "A" or timePeriod

Related Code
Same issue as found on this Ionic Forum Question

Expected Behavior
Expect to have a variable for the am/pm variables that we can translate

@ionitron-bot ionitron-bot bot added the triage label Nov 8, 2018
@alexsilvar
Copy link

Can I take it? I have some idea how to handle it.

@paulstelzer
Copy link
Contributor

@alexsilvar Of course, just send a PR, that would be great :)

@paulstelzer paulstelzer added needs: investigation package: core @ionic/core package type: feature request a new feature, enhancement, or improvement and removed triage needs: investigation package: core @ionic/core package labels Dec 7, 2018
@brandyscarney brandyscarney added the package: core @ionic/core package label Jun 5, 2019
@ionitron-bot
Copy link

ionitron-bot bot commented Jun 4, 2020

Thanks for the issue! This issue is being closed due to inactivity. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

Thank you for using Ionic!

@ionitron-bot ionitron-bot bot closed this as completed Jun 4, 2020
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Jun 4, 2020
@ionic-team ionic-team unlocked this conversation Jun 4, 2020
@liamdebeasi liamdebeasi reopened this Jun 4, 2020
@vijayan007
Copy link

Any plans to address this?

@vijayan007
Copy link

  • For English: shortTimePeriod="AM,PM"
  • For Tamil: shortTimePeriod="கா,மா"

@1001daysofcode
Copy link
Author

?

@sean-perkins sean-perkins changed the title Translate the Time Period (am/pm) in ion-datetime feat: Translate the Time Period (am/pm) in ion-datetime Dec 19, 2021
@sean-perkins sean-perkins added type: feature request a new feature, enhancement, or improvement and removed type: feature request a new feature, enhancement, or improvement labels Dec 19, 2021
@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #25389, and this feature will be available in an upcoming minor release of Ionic.

@ionitron-bot
Copy link

ionitron-bot bot commented Aug 25, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: feature request a new feature, enhancement, or improvement
Projects
None yet
Development

No branches or pull requests

7 participants