Skip to content

Commit

Permalink
fix(angular): tab-bar slot=top (#16727)
Browse files Browse the repository at this point in the history
fixes #16722
  • Loading branch information
manucorporat authored Dec 13, 2018
1 parent a27fdc3 commit d4e4b52
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 20 deletions.
1 change: 1 addition & 0 deletions angular/src/directives/navigation/ion-tabs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { RouteView } from './stack-utils';
@Component({
selector: 'ion-tabs',
template: `
<ng-content select="[slot=top]"></ng-content>
<div class="tabs-inner">
<ion-router-outlet #outlet tabs="true"></ion-router-outlet>
</div>
Expand Down
31 changes: 12 additions & 19 deletions angular/test/test-app/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion angular/test/test-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"@angular/platform-browser": "~7.1.0",
"@angular/platform-browser-dynamic": "~7.1.0",
"@angular/router": "~7.1.0",
"@ionic/angular": "^4.0.0-beta.16",
"@ionic/angular": "^4.0.0-beta.18",
"core-js": "^2.5.4",
"rxjs": "~6.3.3",
"tslib": "^1.9.0",
Expand Down

1 comment on commit d4e4b52

@edotassi
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this be released in the beta 19?

Please sign in to comment.