Skip to content

Commit

Permalink
fix(datetime): switching presentation closes month/year picker (#25667)
Browse files Browse the repository at this point in the history
  • Loading branch information
liamdebeasi authored Jul 26, 2022
1 parent db28794 commit 57a21ad
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 0 deletions.
7 changes: 7 additions & 0 deletions core/src/components/datetime/datetime.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -1027,6 +1027,13 @@ export class Datetime implements ComponentInterface {
this.destroyInteractionListeners();

this.initializeListeners();

/**
* The month/year picker from the date interface
* should be closed as it is not available in non-date
* interfaces.
*/
this.showMonthAndYear = false;
}

private processValue = (value?: string | null) => {
Expand Down
21 changes: 21 additions & 0 deletions core/src/components/datetime/test/presentation/datetime.e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,27 @@ test.describe('datetime: presentation', () => {

expect(ionChangeSpy.length).toBe(1);
});

test('switching presentation should close month/year picker', async ({ page }, testInfo) => {
await test.skip(testInfo.project.metadata.rtl === true, 'This feature does not have RTL specific behaviors.');

await page.setContent(`
<ion-datetime presentation="date"></ion-datetime>
`);

await page.waitForSelector('.datetime-ready');

const datetime = page.locator('ion-datetime');
const monthYearButton = page.locator('ion-datetime .calendar-month-year');
await monthYearButton.click();

await expect(datetime).toHaveClass(/show-month-and-year/);

await datetime.evaluate((el: HTMLIonDatetimeElement) => (el.presentation = 'time'));
await page.waitForChanges();

await expect(datetime).not.toHaveClass(/show-month-and-year/);
});
});

test.describe('datetime: presentation: time', () => {
Expand Down

0 comments on commit 57a21ad

Please sign in to comment.