Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(tabs): update usage section to latest #163

Closed
brandyscarney opened this issue Oct 31, 2018 · 4 comments · Fixed by ionic-team/ionic-framework#16348
Closed

docs(tabs): update usage section to latest #163

brandyscarney opened this issue Oct 31, 2018 · 4 comments · Fixed by ionic-team/ionic-framework#16348

Comments

@brandyscarney
Copy link
Member

The usage section for tabs is outdated / not up to date with beta 14: https://github.com/ionic-team/ionic/tree/master/core/src/components/tabs/usage

Need to review the readme too and probably the component docs
@brandyscarney brandyscarney mentioned this issue Oct 31, 2018
Closed
@brandyscarney
Copy link
Member Author

also, the tab-button API docs show ion-tab-bar instead of ion-tab-button: https://beta.ionicframework.com/docs/api/tab-button

@peterpeterparker
Copy link

also the doc https://beta.ionicframework.com/docs/api/tab-bar display <ion-tab-bar slot="bottom"/> where actually it should be <ion-tab-bar placement="bottom"/> (not a slot, cf.: https://github.com/ionic-team/ionic/blob/018fb9876f10eeae37e45fd1e2b9a6315db69067/core/src/components/tab-bar/tab-bar.tsx)

@brandyscarney
Copy link
Member Author

@peterpeterparker Placement is removed in master: https://github.com/ionic-team/ionic/blob/master/core/src/components/tab-bar/tab-bar.tsx

It should be slot. 🙂

@peterpeterparker
Copy link

@brandyscarney funny I just noticed it too 5 minutes ago 😆 turns out one of my many Ionic projects was not yet actualized. Sorry for my wrong comment, you are right of course

brandyscarney added a commit to ionic-team/ionic-framework that referenced this issue Nov 20, 2018
@brandyscarney
docs(tabs): update usage and button readme
2ce45b5 
fixes ionic-team/ionic-docs#163
@brandyscarney brandyscarney mentioned this issue Nov 20, 2018
Merged
brandyscarney added a commit to ionic-team/ionic-framework that referenced this issue Nov 21, 2018
@brandyscarney
fix(tab-bar): update to match MD design and remove transforms (#16348)
bc3e192 
Updates the tab-bar to match the MD bottom navigation spec: https://material.io/design/components/bottom-navigation.html#specs

Changes proposed in this pull request:
- moved flex properties to host, inherit in child anchor element
  - this allows the user to customize the tab-button flex properties & fixes #16231
- increased letter spacing
- removed transforms / transitions on active tab
- decreased badge size, add badge styling when empty for MD
- fix badge positioning on both iOS and MD
- updates e2e tests, adds a preview test for tab-bar
- updates documentation surrounding tabs

fixes #16231
fixes ionic-team/ionic-docs#175
fixes ionic-team/ionic-docs#163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tab-bar): update to match MD design and remove transforms ionic-team/ionic-framework
2 participants
@brandyscarney @peterpeterparker