chore(config): remove crosswalk from config.xml and package.json #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually the cause of this is that cordova-android has minor version with breaking changes or simple incompatibly with android gradle plugin (3.0.0). See apache/cordova-android#417 Another fix would be to set cordova-android version to something before 6.4.0. If this example still wants to use cordova-crosswalk-plugin then this would be better solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though crosswalk was removed in #432 it was added right back in 8a62ca4
Crosswalk is not being maintained anymore and this app fails for me when using newest android engine and crosswalk plugin with error about requiring to define
flavorDimensions(though this is more crosswalk problem).